Do not use (deprecated) class, to be removed in future releases. #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
added a commit
that referenced
this pull request
Mar 28, 2020
…yan) This PR was squashed before being merged into the 1.0-dev branch (closes #570). Discussion ---------- Fixing deprecated Doctrine\Common code in templates Fixes #570 #560, #524, #528, #519 #570 Commits ------- befcabc Adding a hack to work around a remaining direct deprecation in PHP < 7.3 845fdf0 updating cs 54e356e Fixing bad sprintf e953daf Fixing deprecated Doctrine\Common code in templates
Member
|
Fully fixed in #570 :). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since doctrine itself recommends to use
Doctrine\Persistence\ManagerRegistry, lets not useDoctrine\Common\Persistence\ManagerRegistry. This should be an easy merge as they seem to be signature compatible.